User with 0 quota, file uploaded shows up in "My Files" even it said "Could not upload"

[hood]

With user with 0 Byte quota.
I tried to upload a file (Since I thought 0 may means unlimited quota).
It said upload failed message, then I went to My Files section, the file actually shows up, and I couldn't delete this file.

Cheers, thanks for all the work!

[sebastian]

Thank you for reporting the bug.

Quota of 0 Byte should mean "no upload allowed". So your reported experience is a bug in upload() function of app/controllers/browser_controller.php.

I think having an upload quota covers the general case. I added also #73 to cover an global upload quota of the gallery.

Do you have cases where you need unlimited upload quota? If so, this unlimited quota feature could be added as the feature request.

I would like also to mention that phTagr could import media of external directories which are not considered in the quota check. phTagr reads and stores meta information to external directories, but never deletes these external files.

In contrast Internal files are uploaded files and are stored in the users upload directory in app/users/USER_ID/files.

[sebastian]

Fixed the quota check in r541 which denies the upload of files if quota is 0.